Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Debt] Migrate from framer-motion to motion #12373

Merged
merged 1 commit into from
Dec 27, 2024
Merged

[Debt] Migrate from framer-motion to motion #12373

merged 1 commit into from
Dec 27, 2024

Conversation

esizer
Copy link
Member

@esizer esizer commented Dec 24, 2024

🤖 Resolves #12352

👋 Introduction

Moves from the old name framer-motion to the new independent motion library

🕵️ Details

This is the same library, it has just been decoupled from framer to be an independent library.

🧪 Testing

  1. Install new deps pnpm i
  2. Build app pnpm run dev:fresh
  3. Confirm animations still run as expected

@mnigh mnigh self-requested a review December 24, 2024 17:27
mnigh
mnigh reviewed Dec 24, 2024
View reviewed changes
Copy link
Contributor

@mnigh mnigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about dependency, otherwise looks good to me.

pnpm-lock.yaml Show resolved Hide resolved
mnigh
mnigh approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@mnigh mnigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@esizer esizer added this pull request to the merge queue Dec 27, 2024
Merged via the queue into main with commit 27ae535 Dec 27, 2024
16 checks passed
@esizer esizer deleted the 12352-migrate-to-motion branch December 27, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnigh mnigh mnigh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ Migrate from framer-motion to motion
2 participants
@esizer @mnigh