Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debt] Remove sanitize string function #12359

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

esizer
Copy link
Member

@esizer esizer commented Dec 19, 2024

🤖 Resolves #11370

👋 Introduction

Removes our sanitizeString function in favour of adding characters to the firewall allow list.

🧪 Testing

  1. Build app pnpm run dev:fresh
  2. Confirm you can submit forms with text inputs

@vd1992
Copy link
Contributor

vd1992 commented Dec 19, 2024

Hm, I think the important thing to check here is whether the Narrow No-Break Space was adjusted for in the firewall. Only safe to remove the function if it is the case 😆

@petertgiles
Copy link
Contributor

whether the Narrow No-Break Space was adjusted for in the firewall

Try it out! Graphiql is down in prod, unfortunately, but you could still try it with browser edit and resend or postman.

@brindasasi brindasasi self-requested a review December 30, 2024 14:53
@petertgiles petertgiles self-requested a review January 2, 2025 16:13
Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! I used postman to send a nnbsp directly to the prod API and it worked fine.

@esizer esizer added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit 0e2d164 Jan 2, 2025
12 checks passed
@esizer esizer deleted the 11370-remove-ts-sanitize-string branch January 2, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ Remove sanitizeString
3 participants