Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debt] Remove sanitize string function #12359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

esizer
Copy link
Member

@esizer esizer commented Dec 19, 2024

🤖 Resolves #11370

👋 Introduction

Removes our sanitizeString function in favour of adding characters to the firewall allow list.

🧪 Testing

  1. Build app pnpm run dev:fresh
  2. Confirm you can submit forms with text inputs

@vd1992
Copy link
Contributor

vd1992 commented Dec 19, 2024

Hm, I think the important thing to check here is whether the Narrow No-Break Space was adjusted for in the firewall. Only safe to remove the function if it is the case 😆

@petertgiles
Copy link
Contributor

whether the Narrow No-Break Space was adjusted for in the firewall

Try it out! Graphiql is down in prod, unfortunately, but you could still try it with browser edit and resend or postman.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ Remove sanitizeString
3 participants