Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Account settings auth redirect #12358

Merged
merged 2 commits into from
Dec 20, 2024
Merged

[Fix] Account settings auth redirect #12358

merged 2 commits into from
Dec 20, 2024

Conversation

esizer
Copy link
Member

@esizer esizer commented Dec 19, 2024

🤖 Resolves #12353

👋 Introduction

Adds the RequireAuth wrapper to the account settings page for the redirect.

🧪 Testing

  1. Build app pnpm run dev:fresh
  2. Ensure you are not authenticated
  3. Navigate to /applicant/settings
  4. Confirm you are redirected to the login info page
  5. Confirm completing the login takes you back to /applicant/settings

petertgiles
petertgiles approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. ❤️

@esizer esizer added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit ad77880 Dec 20, 2024
11 checks passed
@esizer esizer deleted the 12353-fix-applicant-settings-auth branch December 20, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertgiles petertgiles petertgiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Clicking the unsubscribe link in the email does not redirect to login
2 participants
@esizer @petertgiles