[Accessibility] Role menu aria text added #12225
Open
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esizer
reviewed
Dec 9, 2024
Comment on lines
+160
to
+166
| aria-label={intl.formatMessage({ | ||
| defaultMessage: | ||
| "Select a different role to access its corresponding tools and information", | ||
| id: "sSbt7W", | ||
| description: | ||
| "Aria text to describe what the purpose of the role menu is", | ||
| })} |
There was a problem hiding this comment.
So, it looks like aria-description is not ready for production yet 😢 So not using it was the right call. However, with aria-label, we no longer know what the current role is.
We should get both contexts for this and right now, I am not sure how we can do that 🤔
There was a problem hiding this comment.
Tricky, tricky then huh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Resolves #11973
👋 Introduction
Added the context providing information.
I found aria-description did nothing so I went with label instead. I was using Microsoft Narrator
🧪 Testing