Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠️ PHPUnit tests using deprecated codecov argument #12389

Closed
1 task
mnigh opened this issue Dec 27, 2024 · 0 comments · Fixed by #12390
Closed
1 task

🛠️ PHPUnit tests using deprecated codecov argument #12389

mnigh opened this issue Dec 27, 2024 · 0 comments · Fixed by #12390
Assignees
@mnigh
Labels
tooling Tooling, automation and CI to support development.

Comments

@mnigh
Copy link
Contributor

mnigh commented Dec 27, 2024

🛠️ Tooling

PHPUnit tests using deprecated codecov argument.

🕵️ Details

gc-digital-talent/.github/workflows/phpunit.yml

Line 71 in 6ef9044

file: coverage.xml

Warning

The following arguments have been changed

file (this has been deprecated in favor of files)
plugin (this has been deprecated in favor of plugins)

https://github.com/codecov/codecov-action/releases/tag/v5.0.0

Screenshot

Screen Shot 2024-12-27 at 12 23 20

🙋‍♀️ Proposed Solution

Replace file: coverage.xml with files: coverage.xml.

✅ Acceptance Criteria

  • no codecov warnings in CI for PHPUnit tests
@mnigh mnigh added the tooling Tooling, automation and CI to support development. label Dec 27, 2024
@mnigh mnigh self-assigned this Dec 27, 2024
@mnigh mnigh moved this to 🏗 In progress in GC Digital Talent Dec 27, 2024
@mnigh mnigh mentioned this issue Dec 27, 2024
Merged
@mnigh mnigh moved this from 🏗 In progress to 👀 In review in GC Digital Talent Dec 27, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in GC Digital Talent Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnigh mnigh

Labels
tooling Tooling, automation and CI to support development.
Projects
GC Digital Talent
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tooling] Fixes codecov-action argument GCTC-NTGC/gc-digital-talent
1 participant
@mnigh