Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⌨ Role menu purpose not apparent to screen readers #11973

Open
2 tasks
esizer opened this issue Nov 14, 2024 · 3 comments · May be fixed by #12225
Open
2 tasks

⌨ Role menu purpose not apparent to screen readers #11973

esizer opened this issue Nov 14, 2024 · 3 comments · May be fixed by #12225
Assignees
Labels
accessibility Issues related to accessibility blocked Blocked by work that's out-of-scope of the issue itself.

Comments

@esizer
Copy link
Member

esizer commented Nov 14, 2024

⌨ Accessibility Issue

The purpose of the new role dropdown menu lacks context for screen readers.

🦋 Expected Behaviour

The purpose of the menu is clear.

🕵️ Details

The new role dropdown menu uses the current role as the name which can be confusing. When using a screen reader, all you hear is something like "Button applicant collapsed, 3 items". For someone using the site who is not already aware of this, they may not understand what the dropdown does.

📋 Steps to Reproduce

  1. Login with someone who has multiple roles [email protected]
  2. Start any screen reader
  3. Tab focus until you land on the role dropdown
  4. Observe what is read out

🙋‍♀️ Proposed Solution

~~We may want to add an aria-label and possibly an aria-description to notify users what the dropdown does 🤔 ~~

We took a look and unfortunately, aria-description is not fully supported yet. The interim solution would to add a label to the input like "Current role" and associate it with the button with an aria-describedby but that will require visual changes so we will need an updated design.

Localized Copy

English: Select a different role to access its corresponding tools and information.
French: Sélectionnez un rôle différent pour accéder aux outils et informations correspondants.

✅ Acceptance Criteria

  • Add "Current role" label (not a label element thought 😅 ) before the button (requires design change)
  • Associated the current role specified text to the role menu as aria-describedby
@esizer esizer added the accessibility Issues related to accessibility label Nov 14, 2024
@tristan-orourke tristan-orourke added the review in refinement Ready to be looked at and pulled into "ready to dev" label Nov 15, 2024
@esizer esizer changed the title ⌨ Role menu purpose not apparently to screen readers ⌨ Role menu purpose not apparent to screen readers Nov 16, 2024
@tristan-orourke
Copy link
Member

@esizer and @NienkeBr, could you try to come up with a useful description for this?

@NienkeBr
Copy link
Contributor

NienkeBr commented Nov 28, 2024

Would something like this work:

  • Select a different role to access its corresponding tools and information.
    • For French: Sélectionnez un rôle différent pour accéder aux outils et informations correspondants.

@tristan-orourke tristan-orourke removed the review in refinement Ready to be looked at and pulled into "ready to dev" label Dec 2, 2024
@tristan-orourke tristan-orourke moved this to 🏭 Ready for Estimate in GC Digital Talent Dec 2, 2024
@tristan-orourke tristan-orourke moved this from 🏭 Ready for Estimate to 📋 Ready for Dev in GC Digital Talent Dec 4, 2024
@vd1992 vd1992 self-assigned this Dec 6, 2024
@vd1992 vd1992 linked a pull request Dec 6, 2024 that will close this issue
@vd1992 vd1992 moved this from 📋 Ready for Dev to 👀 In review in GC Digital Talent Dec 6, 2024
@tristan-orourke tristan-orourke added the blocked Blocked by work that's out-of-scope of the issue itself. label Dec 10, 2024
@tristan-orourke tristan-orourke moved this from 👀 In review to 📋 Ready for Dev in GC Digital Talent Dec 11, 2024
@esizer
Copy link
Member Author

esizer commented Dec 12, 2024

After speaking with @MaddyDaigle , we think we may need to just stick some "Current role" prefix onto the button for now while we explore better solutions.

Since this seems to be a novel pattern, we are still investigating how it can be immediately apparent to users on the purpose of the drop down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility blocked Blocked by work that's out-of-scope of the issue itself.
Projects
Status: 📋 Ready for Dev
Development

Successfully merging a pull request may close this issue.

4 participants