Skip to content

Commit

Permalink
Merge branch 'main' into 10368-remove-teams-ui
Browse files Browse the repository at this point in the history
  • Loading branch information
mnigh committed Dec 27, 2024
2 parents b68274f + 4606a99 commit 17b7152
Show file tree
Hide file tree
Showing 42 changed files with 853 additions and 339 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/phpunit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,6 @@ jobs:
uses: codecov/codecov-action@v5
with:
token: ${{ secrets.CODECOV_TOKEN }}
file: coverage.xml
files: coverage.xml
flags: integrationtests
fail_ci_if_error: false
6 changes: 5 additions & 1 deletion api/app/Models/Classification.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ protected function displayName(): Attribute

/**
* Used to limit the results for the search page input
* to IT up to level 5 and PM up to level 6 and CR level 4
* to IT up to level 5; PM up to level 6; CR level 4; EX level 3, EX level 4.
*
* TODO: Update in #9483 to derive from new column
*/
Expand All @@ -75,6 +75,10 @@ public static function scopeAvailableInSearch(Builder $query, bool $availableInS
$query->where('group', 'PM')->where('level', '<=', 6);
})->orWhere(function ($query) {
$query->where('group', 'CR')->where('level', '=', 4);
})->orWhere(function ($query) {
$query->where('group', 'EX')->where('level', '=', 3);
})->orWhere(function ($query) {
$query->where('group', 'EX')->where('level', '=', 4);
});
}
}
8 changes: 8 additions & 0 deletions api/database/seeders/ClassificationSeeder.php
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,14 @@ public function run()
'max_salary' => 198939,
]
),
array_merge(
$exGroup,
[
'level' => 4,
'min_salary' => 193896,
'max_salary' => 228114,
]
),
array_merge(
$crGroup,
[
Expand Down
1 change: 0 additions & 1 deletion api/graphql/schema.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,6 @@ type GeneralQuestion {
pool: Pool @belongsTo
question: LocalizedString
sortOrder: Int @rename(attribute: "sort_order")
# generalQuestionResponses: [GeneralQuestionResponse] @hasMany # TODO: uncomment this and add sensible permission check
}

type ScreeningQuestion {
Expand Down
8 changes: 4 additions & 4 deletions apps/web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,15 @@
"@tanstack/react-table": "^8.20.6",
"dataloader": "^2.2.3",
"date-fns": "^3.6.0",
"framer-motion": "^11.15.0",
"graphql": "^16.10.0",
"lodash": "^4.17.21",
"motion": "^11.15.0",
"react": "^18.3.1",
"react-dom": "^18.2.0",
"react-helmet-async": "^2.0.5",
"react-hook-form": "^7.54.1",
"react-hook-form": "^7.54.2",
"react-intl": "^7.0.4",
"react-router": "^7.0.2",
"react-router": "^7.1.1",
"react-to-print": "^2.15.1",
"urql": "^4.2.1"
},
Expand Down Expand Up @@ -98,7 +98,7 @@
"ts-node": "^10.9.2",
"tsconfig": "workspace:*",
"typescript": "^5.7.2",
"vite": "^6.0.4",
"vite": "^6.0.5",
"vite-plugin-compression2": "^1.3.3",
"vite-plugin-html": "^3.2.2"
}
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/Context/ContextProvider.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { HelmetProvider } from "react-helmet-async";
import { MotionConfig, LazyMotion, domAnimation } from "framer-motion";
import { MotionConfig, LazyMotion, domAnimation } from "motion/react";
import { ReactNode } from "react";

import { AppInsightsProvider } from "@gc-digital-talent/app-insights";
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/Layout/IAPLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Fragment } from "react";
import { useIntl } from "react-intl";
import { useLocation, Outlet, ScrollRestoration } from "react-router";
import { ApplicationInsights } from "@microsoft/applicationinsights-web";
import { AnimatePresence } from "framer-motion";
import { AnimatePresence } from "motion/react";

import {
NestedLanguageProvider,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useEffect, useRef, useState } from "react";
import { useIntl } from "react-intl";
import { AnimatePresence, m, usePresence } from "framer-motion";
import { AnimatePresence, m, usePresence } from "motion/react";
import BellAlertIcon from "@heroicons/react/24/outline/BellAlertIcon";
import BellAlertIconSm from "@heroicons/react/20/solid/BellAlertIcon";
import XMarkIcon from "@heroicons/react/20/solid/XMarkIcon";
Expand Down
10 changes: 5 additions & 5 deletions apps/web/src/components/PoolCandidatesTable/tableMessages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ const messages = defineMessages({
id: "/LGiVB",
},
candidateName: {
defaultMessage: "Candidate Name",
id: "p/Qp/u",
defaultMessage: "Candidate name",
id: "awEvCF",
description: "Title displayed on the Pool Candidates table name column.",
},
skillCount: {
Expand All @@ -23,10 +23,10 @@ const messages = defineMessages({
"Title displayed on the Pool Candidates table Current Location column.",
},
dateReceived: {
defaultMessage: "Date Received",
id: "3eNQnt",
defaultMessage: "Date received",
id: "fI0idr",
description:
"Title displayed on the Pool Candidates table Date Received column.",
"Title displayed on the Pool Candidates table Date received column.",
},
rowSelection: {
defaultMessage: "Row Selection",
Expand Down
7 changes: 0 additions & 7 deletions apps/web/src/components/SearchRequestFilters/FilterBlock.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ import isArray from "lodash/isArray";
import { ReactNode } from "react";

import { Maybe } from "@gc-digital-talent/graphql";
import { commonMessages } from "@gc-digital-talent/i18n";

interface FilterBlockProps {
title: string;
content?: Maybe<string | ReactNode> | Maybe<string[]>;
Expand Down Expand Up @@ -49,8 +47,6 @@ const FilterBlockContent = ({
};

const FilterBlock = ({ title, content }: FilterBlockProps) => {
const intl = useIntl();

return (
<div data-h2-padding="base(0, 0, x1, 0)">
<p
Expand All @@ -59,9 +55,6 @@ const FilterBlock = ({ title, content }: FilterBlockProps) => {
data-h2-font-weight="base(600)"
>
<span data-h2-display="base(inline)">{title}</span>
<span data-h2-display="base(none) p-tablet(inline)">
{intl.formatMessage(commonMessages.dividingColon)}
</span>
</p>
<FilterBlockContent content={content} />
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,8 @@ const ApplicantFilters = ({
<FilterBlock
title={intl.formatMessage({
defaultMessage:
"Conditions of employment / Operational requirements",
id: "cMsRgt",
"Conditions of employment or operational requirements",
id: "SNxTm+",
description:
"Title for operational requirements section on summary of filters section",
})}
Expand Down Expand Up @@ -430,8 +430,8 @@ const SearchRequestFilters = ({
<FilterBlock
title={intl.formatMessage({
defaultMessage:
"Conditions of employment / Operational requirements",
id: "cMsRgt",
"Conditions of employment or operational requirements",
id: "SNxTm+",
description:
"Title for operational requirements section on summary of filters section",
})}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,8 @@ const SearchRequestTable = ({ title }: SearchRequestTableProps) => {
id: "requestedDate",
enableColumnFilter: false,
header: intl.formatMessage({
defaultMessage: "Date Received",
id: "r2gD/4",
defaultMessage: "Date received",
id: "m0Qcow",
description:
"Title displayed on the search request table requested date column.",
}),
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/SelfDeclaration/CommunityIcon.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { AnimatePresence, m } from "framer-motion";
import { AnimatePresence, m } from "motion/react";
import { useFormContext } from "react-hook-form";

import firstNationsOn from "~/assets/img/first-nations-true.webp";
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/SpinnerIcon/SpinnerIcon.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { m, useReducedMotion } from "framer-motion";
import { m, useReducedMotion } from "motion/react";
import ArrowPathIcon from "@heroicons/react/20/solid/ArrowPathIcon";

import { IconProps } from "@gc-digital-talent/ui";
Expand Down
Loading

0 comments on commit 17b7152

Please sign in to comment.