A stupid workaround to add continues scanning feature. #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Thank you very much for this PR! Really appreciate it and will look into it. I am currently working on splitting this library into view and compose version. The plan is to allow easy embedding of the scanner ui (so no extra Activity in this case). This would also allow exposing the scan results as a state flow, so that all scan results can be handled. But will also check if I can adapt some of your changes. |
|
@G00fY2 Do you think we can come in and contribute in the process? I don't see any draft PR for this migration. I'd love to contribute here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workaround works for me but it needs alot of changes.