Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for breaking vcpkg changes #493

Merged
merged 15 commits into from
Jan 20, 2025
Merged

Conversation

marcin-krystianc
Copy link
Contributor

@marcin-krystianc marcin-krystianc commented Jan 14, 2025

There is an ongoing process for reorganizing vcpkg, but it broke our CI:

I'm unsure how to fix it properly, but with this change, we at least make sure that we use vcpkg repo prior to the vcpkgTools.xml related changes and unblock our CI.

@marcin-krystianc marcin-krystianc marked this pull request as ready for review January 14, 2025 11:57
Copy link
Contributor

@adamreeve adamreeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine as a temporary workaround but we should figure out how to make our CI work with the latest vcpkg soon

@marcin-krystianc marcin-krystianc merged commit 9eaebfd into master Jan 20, 2025
37 checks passed
@marcin-krystianc marcin-krystianc deleted the dev-20250114-ci branch January 20, 2025 08:02
adamreeve added a commit to adamreeve/ParquetSharp that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants