Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump parquet-cpp-arrow to 18.1.0 #492

Merged
merged 5 commits into from
Jan 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ devcontainer exec dotnet test csharp.test
Building ParquetSharp natively requires the following dependencies:
- A modern C++ compiler toolchain
- .NET SDK 8.0
- Apache Arrow (15.0.2)
- Apache Arrow (18.1.0)

For building Arrow (including Parquet) and its dependencies, we recommend using Microsoft's [vcpkg](https://vcpkg.io).
The build scripts will use an existing vcpkg installation if either of the `VCPKG_INSTALLATION_ROOT` or `VCPKG_ROOT` environment variables are defined, otherwise vcpkg will be downloaded into the build directory.
Expand Down
4 changes: 2 additions & 2 deletions csharp.test/TestPhysicalTypeRoundtrip.cs
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ private static void AssertReadRoundtrip(ResizableBuffer buffer, ExpectedColumn[]

var numRows = expectedColumns.First().Values.Length;

Assert.AreEqual("parquet-cpp-arrow version 17.0.0", fileMetaData.CreatedBy);
Assert.AreEqual("parquet-cpp-arrow version 18.1.0", fileMetaData.CreatedBy);
Assert.AreEqual(new Dictionary<string, string> {{"case", "Test"}, {"Awesome", "true"}}, fileMetaData.KeyValueMetadata);
Assert.AreEqual(expectedColumns.Length, fileMetaData.NumColumns);
Assert.AreEqual(numRows, fileMetaData.NumRows);
Expand All @@ -174,7 +174,7 @@ private static void AssertReadRoundtrip(ResizableBuffer buffer, ExpectedColumn[]
// The parquet format only stores an integer file version (1 or 2) and
// 2 gets mapped to the latest 2.x version.
Assert.AreEqual(ParquetVersion.PARQUET_2_6, fileMetaData.Version);
Assert.AreEqual("parquet-cpp-arrow version 17.0.0", fileMetaData.WriterVersion.ToString());
Assert.AreEqual("parquet-cpp-arrow version 18.1.0", fileMetaData.WriterVersion.ToString());

using var rowGroupReader = fileReader.RowGroup(0);
var rowGroupMetaData = rowGroupReader.MetaData;
Expand Down
2 changes: 1 addition & 1 deletion csharp.test/TestWriterProperties.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public static void TestDefaultProperties()
{
var p = WriterProperties.GetDefaultWriterProperties();

Assert.AreEqual("parquet-cpp-arrow version 17.0.0", p.CreatedBy);
Assert.AreEqual("parquet-cpp-arrow version 18.1.0", p.CreatedBy);
Assert.AreEqual(Compression.Uncompressed, p.Compression(new ColumnPath("anypath")));
Assert.AreEqual(int.MinValue, p.CompressionLevel(new ColumnPath("anypath")));
Assert.AreEqual(1024 * 1024, p.DataPageSize);
Expand Down
2 changes: 1 addition & 1 deletion csharp/ParquetSharp.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>1591;</NoWarn>
<VersionPrefix>17.0.0-beta1</VersionPrefix>
<VersionPrefix>18.1.0-beta1</VersionPrefix>
<Company>G-Research</Company>
<Authors>G-Research</Authors>
<Product>ParquetSharp</Product>
Expand Down
4 changes: 2 additions & 2 deletions vcpkg.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
"$schema": "https://raw.githubusercontent.com/microsoft/vcpkg-tool/main/docs/vcpkg.schema.json",
"name": "parquetsharp",
"version-string": "undefined",
"builtin-baseline": "e590c2b30c08caf1dd8d612ec602a003f9784b7d",
"builtin-baseline": "6f29f12e82a8293156836ad81cc9bf5af41fe836",
"dependencies": [
"arrow"
],
"overrides": [
{
"name": "arrow",
"version": "17.0.0"
"version": "18.1.0"
adamreeve marked this conversation as resolved.
Show resolved Hide resolved
}
]
}
Loading