Fixed pagination issue in search.py and added corresponding test #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
jamesbraza
reviewed
Feb 3, 2025
dosubot
bot
added
size:S
…e/paper-qa into fix-query-pagination
dosubot
bot
added
size:M
dosubot
bot
added
size:S
jamesbraza
reviewed
Feb 3, 2025
| @pytest.mark.asyncio | ||
| async def test_search_pagination(agent_test_settings: Settings) -> None: | ||
| """Test that pagination works correctly in SearchIndex.query().""" | ||
| index = await get_directory_index(settings=agent_test_settings) |
There was a problem hiding this comment.
One other comment is, this index build in CI is a bit slow.
Can you do this:
- Make an async
pytest.fixturewithsessionscope that does this - Use it in
test_search_pagination,test_deepcopy_env
Then this PR is good to go
There was a problem hiding this comment.
Per in-person convo, agent_test_settings being not session scoped messes this up.
It's too much work to undo this for now, so we can handle this in a separate PR. YAGNI
jamesbraza
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.