Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagates llmclient changes to pqa #839

Merged
merged 53 commits into from
Feb 21, 2025
Merged

Propagates llmclient changes to pqa #839

merged 53 commits into from
Feb 21, 2025
+3,184 −3,144

Conversation

maykcaldas
Copy link
Collaborator

@maykcaldas maykcaldas commented Jan 29, 2025 •
edited
Loading

Sorry, something went wrong.

@maykcaldas maykcaldas self-assigned this Jan 29, 2025
jamesbraza
jamesbraza reviewed Jan 29, 2025
View reviewed changes
maykcaldas and others added 4 commits February 10, 2025 08:46
@maykcaldas
Merge branch 'main' into update-llmclient
Loading
Loading status checks…
2eac706
@maykcaldas
updated uv.lock
Loading
Loading status checks…
5e8c44a
@pre-commit-ci-lite
[pre-commit.ci lite] apply automatic fixes
Loading
Loading status checks…
af2b92b
@maykcaldas
Merge branch 'main' into update-llmclient
Loading
Loading status checks…
ea83591
@maykcaldas maykcaldas marked this pull request as ready for review February 11, 2025 00:03
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 11, 2025
@maykcaldas maykcaldas requested a review from a team February 11, 2025 00:04
@dosubot dosubot bot added the enhancement New feature or request label Feb 11, 2025
jamesbraza
jamesbraza reviewed Feb 11, 2025
View reviewed changes
maykcaldas and others added 5 commits February 10, 2025 16:33
@maykcaldas
Removed deprecation comment and simplified test prompt
bca04bf
@maykcaldas
Removed legacy comment
7ab10dc
@maykcaldas
Fixed typos
6111325
@maykcaldas
Avoided mocking rate_limited
Loading
Loading status checks…
d1d4c38 
Instead, imports it from llmclient and implements a dummy check_rate_limit
@maykcaldas
Merge branch 'main' into update-llmclient
Loading
Loading status checks…
211a5c1
@maykcaldas
Fixed misatributed prompts
Loading
Loading status checks…
5769fdc
jamesbraza
jamesbraza approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@jamesbraza jamesbraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, a long PR but got it over the finish line.

Adios to the confusing run_prompt, hello directly made Messages

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 13, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 19, 2025
@maykcaldas
Removed deprecated task.py file
Loading
Loading status checks…
bdb0a15
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Feb 19, 2025
pre-commit-ci-lite bot and others added 3 commits February 19, 2025 20:49
@maykcaldas maykcaldas changed the base branch from main to fix-aviary-typing February 19, 2025 23:22
Base automatically changed from fix-aviary-typing to main February 19, 2025 23:34
@maykcaldas
Merge branch 'main' into update-llmclient
Loading
Loading status checks…
c449cb4
jamesbraza
jamesbraza approved these changes Feb 20, 2025
View reviewed changes
maykcaldas and others added 10 commits February 19, 2025 17:58
@maykcaldas
fixed typo in mailmap and avoided unneeded dict in formatting string
89d75f0
@maykcaldas
Merge branch 'update-llmclient' of github.com:Future-House/paper-qa i…
Loading
Loading status checks…
d87d932 
…nto update-llmclient
@maykcaldas
Merge branch 'main' into update-llmclient
Loading
Loading status checks…
bc4b3bf
@maykcaldas
Bumped llmclient and ldp versions
b3b0455
@maykcaldas
Merge branch 'update-llmclient' of github.com:Future-House/paper-qa i…
6273c01 
…nto update-llmclient
@maykcaldas
Merge branch 'main' into update-llmclient
Loading
Loading status checks…
1a15993
@maykcaldas
Merge branch 'main' into update-llmclient
Loading
Loading status checks…
5835af7
@maykcaldas
Updated pqa to import from lmi
7a84534
@maykcaldas
Merge branch 'update-llmclient' of github.com:Future-House/paper-qa i…
51f9812 
…nto update-llmclient
@maykcaldas
Updated import to lmi
Loading
Loading status checks…
e30231a
@maykcaldas maykcaldas merged commit 40e2a09 into main Feb 21, 2025
5 checks passed
@maykcaldas maykcaldas deleted the update-llmclient branch February 21, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesbraza jamesbraza

Assignees

@maykcaldas maykcaldas

Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maykcaldas @jamesbraza