Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing flaky test_docs_pickle via retrying #249

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Fixing flaky test_docs_pickle via retrying #249

merged 4 commits into from
Mar 8, 2024

Conversation

jamesbraza
Copy link
Collaborator

https://github.com/whitead/paper-qa/actions/runs/8195942714/job/22415189107 shows test_docs_pickle was flaky.

This PR:

  1. Removes test dir filesystem usage (to allow parallelism in the future)
  2. "Fixes" the flaky test by adding retrying

@jamesbraza jamesbraza added the bug Something isn't working label Mar 8, 2024
@jamesbraza jamesbraza requested a review from whitead March 8, 2024 06:50
@jamesbraza jamesbraza self-assigned this Mar 8, 2024
@whitead whitead merged commit a50dff1 into main Mar 8, 2024
1 check passed
@jamesbraza jamesbraza deleted the flaky-pickle-test branch March 8, 2024 17:30
@jamesbraza jamesbraza mentioned this pull request Mar 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitead whitead Awaiting requested review from whitead

Assignees

@jamesbraza jamesbraza

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @whitead