Skip to content

Commit

Permalink
Fixing incorrect seeding argument due to Pydantic extra="ignore" (#797
Browse files Browse the repository at this point in the history
)
  • Loading branch information
jamesbraza authored Jan 9, 2025
1 parent b1f0eea commit 1881836
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions tests/test_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ async def test___len__(
) -> None:
task_dataset = LitQAv2TaskDataset(
base_query=base_query_request,
question_kwargs={"seed": 42},
question_kwargs={"shuffle_seed": 42},
read_data_kwargs={"seed": 42},
split=split,
)
Expand All @@ -124,9 +124,9 @@ async def test___len__(
obs, _ = await env.reset()
assert (
"Q: SLC14A1 been identified as a specific marker for endothelial"
" cells in which organ?\n\nOptions:\nA) liver\nB) eye\nC)"
" prostate\nD) heart\nE) Insufficient information to answer this"
" question" in (obs[0].content or "")
" cells in which organ?\n\nOptions:\nA) liver\nB) Insufficient"
" information to answer this question\nC) prostate\nD) eye\nE)"
" heart" in (obs[0].content or "")
)
assert env.sources, "Sources need to be accessible"
assert isinstance(
Expand Down Expand Up @@ -163,7 +163,9 @@ async def test_evaluation(
"deleted_dockeys",
}
),
"question_kwargs": {"seed": MultipleChoiceQuestion.SEED_USING_QUESTION},
"question_kwargs": {
"shuffle_seed": MultipleChoiceQuestion.SEED_USING_QUESTION
},
},
)
# NOTE: set base_query after construction of the TaskConfig. because in
Expand Down

0 comments on commit 1881836

Please sign in to comment.