Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kickstart to include theme and silicon user #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alex-fusionauth
Copy link
Contributor

I think we should all probably review and agree on what this looks like, but it is a start.

Each app still needs specific updates based on that app, for instance in the Next.js I still used the HTML/CSS from the template but had to move them into something like app/src/page.tsx. But it keeps a nice look and feel with the theme for the login within FusionAuth.

"asymmetricKeyId": "#{UUID()}",
"clientSecret": "this_really_should_be_a_long_random_alphanumeric_value_but_this_still_works_dont_use_this_in_prod",
"applicationId": "c2aeeb1e-65cd-43c5-9326-02dce5e03705",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wandering what the groups opinion on this was. Should we all share the same sample application or should each quickstart have it's own application. I can see pros and cons of both.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As kickstart will only be read when setting up a new instance, I think we can use the same Id to make things easier.

But I'd love if we had a feature to import a kickstart file into an existing instance, which would require us to have specific Ids for each application.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @vcampitelli . I don't expect anyone to run multiple quickstart applications off the same FusionAuth server.

We do have an open issue on importing a kickstart file into an existing instance.

See FusionAuth/fusionauth-issues#560

"asymmetricKeyId": "#{UUID()}",
"clientSecret": "this_really_should_be_a_long_random_alphanumeric_value_but_this_still_works_dont_use_this_in_prod",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind leaving this as the same for all sample apps. Good to have something awkward there to people know to change.

@@ -40,7 +41,7 @@
"name": "ExampleNodeApp",
"oauthConfiguration" : {
"authorizedRedirectURLs": ["http://localhost:3000/oauth-callback"],
"logoutURL": "http://localhost:4200/",
"logoutURL": "http://localhost:3000/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the quickstarts not being on port 3000 as that is where the astro site wants to run. This could be moved to a variable and then replaced here and line 43 too.

@@ -1,15 +1,16 @@
{
"variables": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would like to see a variable for applicationName too unless we are going to create one generic "Sample App"

@mooreds
Copy link
Contributor

mooreds commented Jul 26, 2023

This makes sense to me. One thing to consider is to not commit the CSS file to this repo but to pull it from here: https://github.com/fusionauth/fusionauth-example-themes when creating a new quickstart.

@mooreds
Copy link
Contributor

mooreds commented Aug 22, 2023

@alex-fusionauth what is left to do on this?

Copy link
Contributor

@mooreds mooreds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes.

@@ -1,15 +1,16 @@
{
"variables": {
"applicationId": "E9FDB985-9173-4E01-9D73-AC2D60D1DC8E",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want this to be the same value.

@@ -40,7 +41,7 @@
"name": "ExampleNodeApp",
"oauthConfiguration" : {
"authorizedRedirectURLs": ["http://localhost:3000/oauth-callback"],
"logoutURL": "http://localhost:4200/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have logoutURL be a variable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants