add Batch method to Rater #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The previous benchmark is wrong 😞 I found a bug in my first implementation, follow the correct benchmark: $ go test -bench .
PASS
BenchmarkNoBatch 20 68577540 ns/op
BenchmarkUsingBatchWithoutAutoUpdate 300 5860922 ns/op
BenchmarkUsingBatchWithAutoUpdate 100 19714002 ns/op
ok github.com/hjr265/too 6.890s |
Happy new year!!! This commits introduces follow features: * `EnableAutoUpdate` and `DisableAutoUpdate` method to engine, with this methods the user can manager the engine auto update similars and suggestions status. * `Update` method to engine, now users can update the similars and suggestions to a user manually. * `Batch` method to rater, now users can rater things in batch, maybe this commit resolve part of the FurqanSoftware#1 In addition to the new API the batch operations is faster than normal operations, follow a Benchmark ``` bash $ go test -bench . PASS BenchmarkNoBatch 20 53301558 ns/op BenchmarkUsingBatch 10000 187824 ns/op ```
|
@dukex This is a really cool pull request! Thanks.. I will take a look at it and merge it asap 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy new year!!!
This commits introduces follow features:
EnableAutoUpdateSimilarsAndSuggestionsandDisableAutoUpdateSimilarsAndSuggestionsmethod to engine, using thismethods the user can manager the engine auto update similars and
suggestions status.
Updatemethod to engine, now users can update the similars andsuggestions to a user manually.
Batchmethod to rater, now users can rater things in batch,maybe this commit resolve part of the Improve engine #1
In addition to the new API the batch operations is faster than normal
operations, follow a Benchmark