Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve engine #1

Open
cajoy opened this issue May 7, 2015 · 4 comments
Open

Improve engine #1

cajoy opened this issue May 7, 2015 · 4 comments

Comments

@cajoy
Copy link

cajoy commented May 7, 2015

Let's say I want to add 50 likes in a sec.

Suggestions and Similarities are going to be updated 50 times during query.

Can I somehow manually run update after I added 50 likes.

Because current implementation is going to burn CPU

Thanks

@hjr265
Copy link
Member

hjr265 commented May 8, 2015

@cajoy You are absolutely right! To be honest, the current implementation is far from ideal, or at least what I want it to be.

I was planning to resume working on this very very soon, and I will probably start with this suggestion of yours. Thank you!

@cajoy
Copy link
Author

cajoy commented May 8, 2015

Sounds good for me. I can try to help if you don't mind..

@hjr265
Copy link
Member

hjr265 commented May 8, 2015

Contributions are always welcome :)

Just, if possible, keep me in the loop before preparing a pull request, so that we don't end up duplicating efforts.

@cajoy
Copy link
Author

cajoy commented May 8, 2015

ok

dukex pushed a commit to dukex/too that referenced this issue Jan 1, 2016
Happy new year!!!

This commits introduces follow features:

* `EnableAutoUpdate` and `DisableAutoUpdate` method to engine, with this
methods the user can manager the engine auto update similars and
suggestions status.

* `Update` method to engine, now users can update the similars and
suggestions to a user manually.

* `Batch` method to rater, now users can rater things in batch,
maybe this commit resolve part of the FurqanSoftware#1

In addition to the new API the batch operations is faster than normal
operations, follow a Benchmark

``` bash
$ go test -bench .
PASS
BenchmarkNoBatch              20          53301558 ns/op
BenchmarkUsingBatch        10000            187824 ns/op
```
dukex pushed a commit to dukex/too that referenced this issue Jan 1, 2016
Happy new year!!!

This commits introduces follow features:

* `EnableAutoUpdate` and `DisableAutoUpdate` method to engine, with this
methods the user can manager the engine auto update similars and
suggestions status.

* `Update` method to engine, now users can update the similars and
suggestions to a user manually.

* `Batch` method to rater, now users can rater things in batch,
maybe this commit resolve part of the FurqanSoftware#1

In addition to the new API the batch operations is faster than normal
operations, follow a Benchmark

``` bash
$ go test -bench .
PASS
BenchmarkNoBatch              20          53301558 ns/op
BenchmarkUsingBatch        10000            187824 ns/op
```
dukex pushed a commit to dukex/too that referenced this issue Jan 1, 2016
Happy new year!!!

This commits introduces follow features:

* `EnableAutoUpdate` and `DisableAutoUpdate` method to engine, with this
methods the user can manager the engine auto update similars and
suggestions status.

* `Update` method to engine, now users can update the similars and
suggestions to a user manually.

* `Batch` method to rater, now users can rater things in batch,
maybe this commit resolve part of the FurqanSoftware#1

In addition to the new API the batch operations is faster than normal
operations, follow a Benchmark

``` bash
$ go test -bench .
PASS
BenchmarkNoBatch              20          53301558 ns/op
BenchmarkUsingBatch        10000            187824 ns/op
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants