Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open chart editor on selected song in freeplay state #4114

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Lasercar
Copy link
Contributor

@Lasercar Lasercar commented Feb 7, 2025

Does this PR close any issues? If so, link them below.

No, but it prevents one from being opened in the future!

Briefly describe the issue(s) fixed.

You no longer have to enter a song first to open the chart editor on that song, you can instead open it directly from in the freeplay state.

Include any relevant screenshots or videos.

2025-02-07.20-35-04.mp4

@github-actions github-actions bot added size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. pr: haxe PR modifies game code. labels Feb 7, 2025
@Lasercar Lasercar changed the base branch from main to develop February 7, 2025 10:36
@Lasercar
Copy link
Contributor Author

Lasercar commented Feb 7, 2025

Aha, this time, I remembered to check that I set the base branch to develop!

@Hundrec
Copy link
Collaborator

Hundrec commented Feb 7, 2025

Absolutely awesome stuff, I'd really like to see this work in game!

@Hundrec Hundrec added type: enhancement Involves an enhancement or new feature. topic: chart editor Related to the operation of the Chart Editor. labels Feb 7, 2025
@Lasercar
Copy link
Contributor Author

Lasercar commented Feb 7, 2025

Wait, wth github bot, this ain't a large PR????

@Hundrec Hundrec added size: medium A medium pull request with 100 or fewer changes. and removed size: large A large pull request with more than 100 changes. labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants