Add ha to monasca barclamp

[samirjorina]

No description provided.

[houndci-bot]

Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||. (https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier)

[houndci-bot]

Metrics/LineLength: Line is too long. [104/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)

[dirkmueller]

thats conflicting with horizon, choose a different port

[samirjorina]

This is just a 'random' port, I only wanted to experiment with HA to make sure I get it right. So can I assume that, in overall, the approach itself is correct?

[jgrassler]

Yes, but please find a port that doesn't clash with anything else. As far as I know we do not have a fixed convention for that. Please correct me if I'm wrong about that, Dirk.

[matrixik]

Done

[dirkmueller]

is this the proper port?

[samirjorina]

Please see above

[jgrassler]

haproxy_loadbalancer "monasca-api" do
  address network_settings 0.0.0.0 # not sure if/how we can specify multiple addresses for this resource but this will make it listen on both the admin and public interface
  port 8070
  servers CrowbarPacemakerHelper.haproxy_servers_for_service(node, "monasca", "monasca-server", "monasca-api")
  )
  action :nothing
end.run_action(:create)

haproxy_loadbalancer "monasca-log-api" do
  address network_settings 0.0.0.0 # not sure if/how we can specify multiple addresses for this resource but this will make it listen on both the admin and public interface
  port 5607
  servers CrowbarPacemakerHelper.haproxy_servers_for_service(node, "monasca", "monasca-server", "monasca-log-api")
  )
  action :nothing
end.run_action(:create)

haproxy_loadbalancer "monasca-logs-search" do
  address network_settings 0.0.0.0 # not sure if/how we can specify multiple addresses for this resource but this will make it listen on both the admin and public interface
  port 5601
  servers CrowbarPacemakerHelper.haproxy_servers_for_service(node, "monasca", "monasca-server", "monasca-logs-search")
  )
  action :nothing
end.run_action(:create)

For this to work you'll need to define the ports where the regular services listen in the HA case in defaults.rb:

default[:monasca][:ha][:ports][:monasca-api] = 18070
default[:monasca][:ha][:ports][:monasca-log-api] = 15607
default[:monasca][:ha][:ports][:monasca-logs-search] = 15601

This is where haproxy_servers_for_service is defined:

https://github.com/crowbar/crowbar-ha/blob/master/chef/cookbooks/crowbar-pacemaker/libraries/helpers.rb#L244

That should make it clear why this works out. It is a bit convoluted, I'm afraid.

Also, I just used the regular listen port for the haproxy_loadbalancer
resource's port attribute above for the sake of clarity. Please don't do this
in your cookbook. Use a helper the way the Barbican
barclamp
does it. You'll find it defined here:

https://github.com/crowbar/crowbar-openstack/blob/master/chef/cookbooks/barbican/libraries/helpers.rb

That helper ensures the actual services listen on the alternate ports (i.e.
18070, 15607, 15601 in our case) in the HA case, and on the regular ports
(8070, 5607, 5601 in our case) otherwise. To that end it provides the network
settings in both the service recipe
and the HA recipe.

[matrixik]

Done

[jgrassler]

Not quite there, yet unfortunately :-(

See my inline comments, especially the second one. I hope that makes things somewhat clearer (our lookup mechanisms for HA/non-HA ports are a bit convoluted). Please feel free to ask if it's not clear (I took a while to wrap my mind around all these twists and turns myself the first time I added HA support to a barclamp...)

[jgrassler]

Yes, but please find a port that doesn't clash with anything else. As far as I know we do not have a fixed convention for that. Please correct me if I'm wrong about that, Dirk.

[jgrassler]

haproxy_loadbalancer "monasca-api" do
  address network_settings 0.0.0.0 # not sure if/how we can specify multiple addresses for this resource but this will make it listen on both the admin and public interface
  port 8070
  servers CrowbarPacemakerHelper.haproxy_servers_for_service(node, "monasca", "monasca-server", "monasca-api")
  )
  action :nothing
end.run_action(:create)

haproxy_loadbalancer "monasca-log-api" do
  address network_settings 0.0.0.0 # not sure if/how we can specify multiple addresses for this resource but this will make it listen on both the admin and public interface
  port 5607
  servers CrowbarPacemakerHelper.haproxy_servers_for_service(node, "monasca", "monasca-server", "monasca-log-api")
  )
  action :nothing
end.run_action(:create)

haproxy_loadbalancer "monasca-logs-search" do
  address network_settings 0.0.0.0 # not sure if/how we can specify multiple addresses for this resource but this will make it listen on both the admin and public interface
  port 5601
  servers CrowbarPacemakerHelper.haproxy_servers_for_service(node, "monasca", "monasca-server", "monasca-logs-search")
  )
  action :nothing
end.run_action(:create)

For this to work you'll need to define the ports where the regular services listen in the HA case in defaults.rb:

default[:monasca][:ha][:ports][:monasca-api] = 18070
default[:monasca][:ha][:ports][:monasca-log-api] = 15607
default[:monasca][:ha][:ports][:monasca-logs-search] = 15601

This is where haproxy_servers_for_service is defined:

https://github.com/crowbar/crowbar-ha/blob/master/chef/cookbooks/crowbar-pacemaker/libraries/helpers.rb#L244

That should make it clear why this works out. It is a bit convoluted, I'm afraid.

Also, I just used the regular listen port for the haproxy_loadbalancer
resource's port attribute above for the sake of clarity. Please don't do this
in your cookbook. Use a helper the way the Barbican
barclamp
does it. You'll find it defined here:

https://github.com/crowbar/crowbar-openstack/blob/master/chef/cookbooks/barbican/libraries/helpers.rb

That helper ensures the actual services listen on the alternate ports (i.e.
18070, 15607, 15601 in our case) in the HA case, and on the regular ports
(8070, 5607, 5601 in our case) otherwise. To that end it provides the network
settings in both the service recipe
and the HA recipe.

[houndci-bot]

Style/TrailingCommaInArguments: Avoid comma after the last parameter of a method call. (https://github.com/bbatsov/ruby-style-guide#no-trailing-params-comma)

[houndci-bot]

Metrics/AbcSize: Assignment Branch Condition size for network_settings is too high. [118.1/30] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricsabcsize, http://c2.com/cgi/wiki?AbcMetric)
Metrics/CyclomaticComplexity: Cyclomatic complexity for network_settings is too high. [11/6]
Metrics/MethodLength: Method has too many lines. [64/50] (https://github.com/bbatsov/ruby-style-guide#short-methods)
Metrics/PerceivedComplexity: Perceived complexity for network_settings is too high. [12/7]