Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve relative path resolution (retry) #801

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

michaelsternberg
Copy link
Contributor

These changes were inspired by issues found in ATARI NOS when trying to open, launch, copy files using relative paths.

  • Fixed a bug in function util_get_canonical_path
    • Previous logic always exited with trailing slash, not good if input ends with a filename. If trailing slash found in input, then it will exist in output. If not then no slash in output.
    • Corrected mistake with condition involving C++ string length.
    • Renamed input arg from prefix to path throughout.
  • In peoples_url_parser, added call to util_get_canonical_path in place of an existing string replace function that substituted '//' with '/'. This should resolve relative paths in general for all protocols.

@tschak909
Copy link
Collaborator

Thank you!

@tschak909 tschak909 merged commit febf356 into FujiNetWIFI:master Oct 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants