Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve relative path resolution #800

Closed
wants to merge 2 commits into from
Closed

Improve relative path resolution #800

wants to merge 2 commits into from

Conversation

michaelsternberg
Copy link
Contributor

  • Fixed a bug in util_canonical_path
    • Previous logic always exited with trailing slash, not good if input ends with a filename. If trailing slash found in input, then it will exist in output. If not then no slash in output.
    • Corrected mistake with condition involving C++ string length .
  • In peoples_url_parser, added call to util_canonical_path instead of replacing '//' with '/'. Mainly, I think this resolves relative paths in general for all protocols.

These changes correct issues found in ATARI NOS when trying to open, launch, copy files using relative paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant