Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move sysinfo behind a feature flag and only enable it for non-macos builds #4750

Merged
merged 7 commits into from
Jul 5, 2023
Merged

refactor: move sysinfo behind a feature flag and only enable it for non-macos builds #4750

merged 7 commits into from
Jul 5, 2023

Conversation

kayagokalp
Copy link
Member

Description

closes #4737.

This PR makes sysinfo an optional dependency which is only enabled for non-macos builds.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@kayagokalp kayagokalp added enhancement New feature or request dependencies labels Jul 5, 2023
@kayagokalp kayagokalp self-assigned this Jul 5, 2023
@kayagokalp kayagokalp requested review from tritao and a team July 5, 2023 13:17
@kayagokalp kayagokalp marked this pull request as ready for review July 5, 2023 14:14
@kayagokalp kayagokalp requested a review from a team July 5, 2023 15:46
@kayagokalp kayagokalp enabled auto-merge (squash) July 5, 2023 20:55
@kayagokalp kayagokalp disabled auto-merge July 5, 2023 20:55
@kayagokalp kayagokalp enabled auto-merge (squash) July 5, 2023 20:55
@kayagokalp kayagokalp merged commit 5dac20e into master Jul 5, 2023
@kayagokalp kayagokalp deleted the kayagokalp/4737 branch July 5, 2023 21:08
@kayagokalp kayagokalp mentioned this pull request Jul 5, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdankel sdankel sdankel approved these changes

@tritao tritao tritao approved these changes

Assignees

@kayagokalp kayagokalp

Labels
dependencies enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move sysinfo dependency behind a feature flag
3 participants
@kayagokalp @tritao @sdankel