Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: dependabot changeset push to use REPO_TOKEN #2639

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Jun 27, 2024

I believe that this is the same issue that plagued the changeset PR, which was solved in #1848.

@github-actions github-actions bot added the chore Issue is a chore label Jun 27, 2024
@nedsalk nedsalk enabled auto-merge (squash) June 27, 2024 13:28
@nedsalk nedsalk removed the chore Issue is a chore label Jun 27, 2024
@maschad
Copy link
Member

maschad commented Jun 27, 2024

Good find, to test this I wonder if we could fork this repo, create a test secret REPO_TOKEN, then modify the dependabot interval to force it to open a PR and then see if the workflow runs there?

@nedsalk
Copy link
Contributor Author

nedsalk commented Jun 28, 2024

@maschad I'm fairly certain that this is the root cause because this solution solved the same problem in #1848. IMO we don't need to go out of our way to test it; merging and verifying the behavior live is okay in this case because, even if this PR is a wrong solution, the workflow itself doesn't block anybody from work nor is it of crucial, "we must get this right the first time" importance.

Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit 🍏

@nedsalk nedsalk disabled auto-merge June 28, 2024 13:16
@nedsalk nedsalk enabled auto-merge (squash) June 28, 2024 13:16
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
80.3%(+0%) 71.8%(+0%) 77.56%(+0%) 80.37%(+0%)
Changed Files:

Coverage values did not change👌.

@nedsalk nedsalk merged commit 63857af into master Jun 28, 2024
19 checks passed
@nedsalk nedsalk deleted the ns/fix/dependabot-workflow-runs-hanging branch June 28, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate dependabot workflow runs hanging
5 participants