Skip to content

chore: test contract deployment with salt #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

chore: test contract deployment with salt #1658

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b4a54e
chore: test contract deployment with salt
hal3e May 13, 2025
c43d4a4
Merge branch 'master' into chore/add-salt-test
hal3e May 13, 2025
7acc0b4
Merge branch 'master' into chore/add-salt-test
hal3e May 14, 2025
c0290a5
Merge branch 'master' into chore/add-salt-test
hal3e May 15, 2025
64353a5
Merge branch 'master' into chore/add-salt-test
hal3e May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions e2e/tests/contracts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,45 @@ async fn test_multiple_args() -> Result<()> {
Ok(())
}

#[tokio::test]
async fn contract_deployment_with_salt() {
Copy link
Member

@MitchTurner MitchTurner May 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reformat this to match our testing format standard:
https://www.notion.so/fuellabs/Engineering-Style-Guide-83ba6fd81f12443796c814ecfc746b39?pvs=4#1742f2293f3180f0931bd1355b0afa13

It looks like the setup_program_test! macro is obscuring some of this, so maybe just

  1. rename the test to clarify what we are doing and what we are expecting: sut__when..._then...
  2. for the given/when/then, maybe just put the //given and //when above the macro and the //then above the asserts

I don't really know what this test is doing other than deploying contract with salt. i.e. I don't know what the alternative case is. Should/can we have another test with the unhappy path? Is it even possible to deploy without salt? This would help elucidate the full picture for a layman looking at the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MitchTurner thanks for the feedback. I will give more context on the test and then we can agree what to do.
We use the same contract code and have 3 Deploy "commands". First deploy will deploy the contract without random salt. The second deploy will do nothing as we already deploy the contract without random salt - the contract_id will be the same. And third deploy will use random salt so we will get a new contract_id.

setup_program_test!(
Wallets("wallet"),
Abigen(Contract(
name = "TestContract",
project = "e2e/sway/contracts/contract_test"
)),
Deploy(
name = "contract_instance_1",
contract = "TestContract",
wallet = "wallet",
random_salt = false,
),
Deploy(
name = "contract_instance_2",
contract = "TestContract",
wallet = "wallet",
random_salt = false,
),
Deploy(
name = "contract_instance_3",
contract = "TestContract",
wallet = "wallet",
random_salt = true,
),
);

assert_eq!(
contract_instance_1.contract_id(),
contract_instance_2.contract_id()
);

assert_ne!(
contract_instance_1.contract_id(),
contract_instance_3.contract_id()
);
}

#[tokio::test]
async fn test_contract_calling_contract() -> Result<()> {
// Tests a contract call that calls another contract (FooCaller calls FooContract underneath)
Expand Down
Loading