Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support the new dry_run interface #1269

Closed
wants to merge 7 commits into from
Closed

fix: support the new dry_run interface #1269

wants to merge 7 commits into from

Conversation

matt-user
Copy link
Contributor

@matt-user matt-user commented Feb 5, 2024 •
edited
Loading

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

I didn't add any tests because I didn't find any previous dry_run tests, but I can if desired.

Blocked until the new release of fuel-core

closes #1266

@matt-user matt-user added the breaking Introduces or requires breaking changes label Feb 5, 2024
@matt-user matt-user self-assigned this Feb 5, 2024
@arboleya arboleya mentioned this pull request Feb 9, 2024
Closed
digorithm
digorithm reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong, but I think @hal3e is addressing this interface change in #1292.

@matt-user
Copy link
Contributor Author

closed in favor of https://github.com/FuelLabs/fuels-rs/pull/1292/files

@matt-user matt-user closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm digorithm left review comments

@hal3e hal3e Awaiting requested review from hal3e hal3e will be requested when the pull request is marked ready for review hal3e is a code owner

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA will be requested when the pull request is marked ready for review MujkicA is a code owner

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet will be requested when the pull request is marked ready for review segfault-magnet is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 will be requested when the pull request is marked ready for review Salka1988 is a code owner

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne Br1ght0ne will be requested when the pull request is marked ready for review Br1ght0ne is a code owner

Assignees

@matt-user matt-user

Labels
blocked breaking Introduces or requires breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the upcoming, new dry_run interface
2 participants
@matt-user @digorithm