Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add test for trig never #1258

Merged
merged 11 commits into from
Mar 26, 2024
Merged

chore: add test for trig never #1258

merged 11 commits into from
Mar 26, 2024

Conversation

MujkicA
Copy link
Contributor

@MujkicA MujkicA commented Jan 23, 2024

Closes #1197

Blocked until FuelLabs/fuel-core#1614 is included in a release.

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@MujkicA MujkicA added tech-debt Improves code quality or safety blocked labels Jan 23, 2024
@MujkicA MujkicA self-assigned this Jan 23, 2024
digorithm
digorithm previously approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- CI failing though

@MujkicA
Copy link
Contributor Author

MujkicA commented Jan 24, 2024 •
edited
Loading

LGTM -- CI failing though

It's the added test, once we have the core update it'll pass

@segfault-magnet
Copy link
Contributor

@MujkicA this doesn't seem ready for merging. Can we convert this to a draft until the updates in core are propagated?

@MujkicA MujkicA marked this pull request as draft February 5, 2024 09:05
@MujkicA MujkicA marked this pull request as ready for review February 16, 2024 14:53
@MujkicA MujkicA marked this pull request as draft February 16, 2024 15:14
@MujkicA MujkicA marked this pull request as ready for review March 14, 2024 14:56
@MujkicA MujkicA requested a review from digorithm March 18, 2024 09:56
hal3e
hal3e approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MujkicA MujkicA enabled auto-merge (squash) March 20, 2024 16:43
@hal3e hal3e removed the blocked label Mar 25, 2024
@MujkicA MujkicA requested review from hal3e and Br1ght0ne March 25, 2024 16:09
@MujkicA MujkicA merged commit e319a44 into master Mar 26, 2024
41 checks passed
@MujkicA MujkicA deleted the feature/trig-never branch March 26, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Salka1988 Salka1988 Salka1988 approved these changes

@iqdecay iqdecay Awaiting requested review from iqdecay

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@hal3e hal3e Awaiting requested review from hal3e hal3e is a code owner

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne Br1ght0ne is a code owner

Assignees

@MujkicA MujkicA

Labels
tech-debt Improves code quality or safety
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manual block production with Trigger::Never leads to error
6 participants
@MujkicA @segfault-magnet @digorithm @Br1ght0ne @Salka1988 @hal3e