-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove async-trait #1244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add in the PR description that this feature was shipped as part of rust 1.75
just so we know.
(sorry if this was discussed previously, I could have missed it) Took another look at this. Seems like some sort of type erasure needs to be done, as explained in E.g., we would have -unresolved_signatures: &[Box<dyn Signer + Send + Sync>],
+unresolved_signatures: &[Box<dyn ErasedSigner + Send + Sync>], |
We discussed using Rust's own async trait support and also seal traits like Because of lack of support for dynamic dispatch, it was agreed that we stick to the async-trait crate for now. |
Checklist