refactor: use a single type for transaction status #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iqdecay
requested review from
digorithm,
hal3e,
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
iqdecay
force-pushed
the
iqdecay/refactor-tx-status
branch
from
fe200ae
to
aa04be4
Compare
MujkicA
approved these changes
Nov 8, 2023
digorithm
approved these changes
Nov 8, 2023
hal3e
approved these changes
Nov 8, 2023
Br1ght0ne
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1179 by removing the
TransactionStatustype that was used in only one place.Further work is needed because the current
TxStatusholds receipts which the clientTransactionStatusdoes not,and doesn't hold some information the client's type does (block id, time, etc).