prepare sdk for fuel-core upgrade
#1170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hal3e
requested review from
digorithm,
iqdecay,
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
github-actions
bot
force-pushed
the
upgrade/fuel-core-master
branch
6 times, most recently
from
96cb71b
to
711b1af
Compare
github-actions
bot
force-pushed
the
upgrade/fuel-core-master
branch
2 times, most recently
from
be4a6a0
to
70b1e52
Compare
hal3e
force-pushed
the
upgrade/fuel-core-master-draft
branch
from
ef16bfe
to
9297769
Compare
### Checklist - [ ] I have linked to any relevant issues. - [ ] I have updated the documentation. - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added necessary labels. - [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers.
This PR closes #1179 by removing the `TransactionStatus` type that was used in only one place. Further work is needed because the current `TxStatus` holds receipts which the client `TransactionStatus` does not, and doesn't hold some information the client's type does (block id, time, etc). --------- Co-authored-by: MujkicA <[email protected]>
|
closed in favor of: #1200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am preparing our SDK for the upcoming release of
fuel-coreand I will use this PR for feedback on some breaking changes.fuel-coresplit upConsesnsusParametersinto smaller parameters and one is calledTxParameters. In the SDK we already have a type calledTxParameters. For now, I import theConsesnsuParametersone asFuelTxParameters. What do you think about this ?Please have a look at the other changes to:
get_message_proofnot usesNonceinstead of the message_idChainIdfor address calculationmanual_blocks_enabledis replaced withdebugin local chain configfee_checked_from_txusesFeeParametersChecklist