Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: predicate witness data access #1156

Merged
merged 22 commits into from
Oct 24, 2023
Merged

fix: predicate witness data access #1156

merged 22 commits into from
Oct 24, 2023

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Oct 5, 2023 •
edited
Loading

close: #1155

Transaction builders do not precompute or estimate predicates anymore when build() is called. Instead, this is done before sending the tx to the client. In addition, ScriptTransaction and CreateTransaction have a new field: is_using_predicates to avoid running the estimation code if no predicates are used.

Checklist

  • I have linked to any relevant issues.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@hal3e hal3e added the bug Something isn't working label Oct 5, 2023
@hal3e hal3e self-assigned this Oct 5, 2023
@Braqzen Braqzen mentioned this pull request Oct 6, 2023
Closed
Salka1988
Salka1988 previously approved these changes Oct 10, 2023
View reviewed changes
@Salka1988 Salka1988 dismissed their stale review October 10, 2023 15:25

Although it is working, it is not finished

@hal3e hal3e changed the title bug: precompute tx after adding witness fix: predicate witness data access Oct 11, 2023
@hal3e hal3e marked this pull request as ready for review October 11, 2023 14:15
iqdecay
iqdecay suggested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some minor remarks

packages/fuels-core/src/types/transaction_builders.rs Outdated Show resolved Hide resolved
packages/fuels-core/src/types/transaction_builders.rs Show resolved Hide resolved
packages/fuels-core/src/types/transaction_builders.rs Show resolved Hide resolved
digorithm
digorithm reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking really good. Just left a minor ask for comments (+ the good suggestions made by everyone else).

packages/fuels-core/src/types/transaction_builders.rs Show resolved Hide resolved
packages/fuels-core/src/types/wrappers/transaction.rs Show resolved Hide resolved
@hal3e hal3e merged commit 66aef68 into master Oct 24, 2023
39 checks passed
@hal3e hal3e deleted the hal3e/bug-precompute-after-add-witness branch October 24, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@MujkicA MujkicA MujkicA approved these changes

@iqdecay iqdecay iqdecay approved these changes

@Salka1988 Salka1988 Salka1988 left review comments

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@xgreenx xgreenx Awaiting requested review from xgreenx

Assignees

@hal3e hal3e

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Predicate can not read manually added witness data
7 participants
@hal3e @digorithm @Br1ght0ne @xgreenx @Salka1988 @MujkicA @iqdecay