-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use fuel-asm
instead of fuel-vm
#1032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but think we want to wait for #997 so we can do the project-wide change @segfault-magnet mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might seem that you can remove even the last reference to fuel_vm
over in provider.rs
.
Take a look at the ProgramState type from the fuel client:
https://github.com/FuelLabs/fuel-core/blob/a57ad421e6b6714038f24815799bf8a499a2fd17/crates/client/src/client/schema/tx.rs#L142
Unfortunately we can not use the client type as |
Use
fuel-asm
directly where possible.Checklist