Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add back doctest testing #1024

Merged
merged 5 commits into from
Jun 30, 2023
Merged

ci: add back doctest testing #1024

merged 5 commits into from
Jun 30, 2023

Conversation

segfault-magnet
Copy link
Contributor

Forgot to add doctests since nextest doesn't test them.

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@segfault-magnet segfault-magnet added the ci GitHub CI build/pipeline label Jun 29, 2023
@segfault-magnet segfault-magnet self-assigned this Jun 29, 2023
digorithm
digorithm approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

iqdecay
iqdecay approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one

@segfault-magnet segfault-magnet merged commit fa3c947 into master Jun 30, 2023
32 checks passed
@segfault-magnet segfault-magnet deleted the feature/add_doctests branch June 30, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm digorithm approved these changes

@iqdecay iqdecay iqdecay approved these changes

@hal3e hal3e hal3e approved these changes

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne Br1ght0ne is a code owner

Assignees

@segfault-magnet segfault-magnet

Labels
ci GitHub CI build/pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@segfault-magnet @digorithm @iqdecay @hal3e