Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to solve macos-latest x86_64-darwin CI build issues for fuel-nightly #69

Merged
merged 6 commits into from
Jun 1, 2023

Conversation

mitchmindtree
Copy link
Contributor

@mitchmindtree mitchmindtree commented Jun 1, 2023

Currently, the frameworks are provided as build inputs - this is an attempt to provide the CoreFoundation framework as a nativeBuildInput to see if it addresses the current CI error tracked in #64.

Edit: Also tried propagatedBuildInputs to see if propagating CoreFoundation to the runtime inputs helped, but no luck.

Edit: Now attempting to remove the most recent manifest sets in order to find the last working version of fuel-nightly so I can diff the two.

@mitchmindtree mitchmindtree changed the title Specify CoreFoundation framework as nativeBuildInput Attempt to solve macos-latest x86_64-darwin CI build issues for fuel-nightly Jun 1, 2023
@mitchmindtree
Copy link
Contributor Author

mitchmindtree commented Jun 1, 2023

OK! It appears the recent CI errors are due to a combination of #70 and #71. See this comment.

This PR reverts the rogue manifests originally added in https://github.com/FuelLabs/fuel.nix/actions/runs/5116169386 to ensure fuel-nightly works on master again.

Both #70 and #71 should be addressed first, then we can address #64 independently.

@mitchmindtree mitchmindtree marked this pull request as ready for review June 1, 2023 05:52
@mitchmindtree mitchmindtree merged commit 045170b into master Jun 1, 2023
@mitchmindtree mitchmindtree deleted the mitchmindtree/fix-ci branch June 1, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants