Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The refresh-cache step in the refresh-manifests job uses previous master (not newly committed master with new manifests) #71

Closed
mitchmindtree opened this issue Jun 1, 2023 · 0 comments · Fixed by #73
Labels
bug Something isn't working

Comments

@mitchmindtree
Copy link
Contributor

In the last successful refresh-manifests action, this step (which only runs on ubuntu-latest, see #70) introduces the forc-nightly version that has been failing on macos-latest CI recently (see #64).

I would have expected the refresh-cache step that follows to have failed, however on closer inspection the macos-latest fuel-nightly job that followed fetches everything directly from cache and doesn't rebuild anything despite the new manifests.

This indicates that the refresh-cache job is likely using master in the state it was in when the whole workflow began and not the new state of master that was committed by the preceding refresh-manifests job.

This explains why we didn't see any CI failure until the next night's refresh-manifests pass where the refresh-cache step did fail.

It's likely best to address this as a part of #70.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant