chore(runnable_task): remove async_trait usage #2660
Conversation
rymnc
requested review from
xgreenx,
Dentosal,
MitchTurner,
netrome,
acerone85,
rafal-ch and
AurelienFT
as code owners
crates/services/p2p/src/service.rs
Outdated
| @@ -878,6 +877,7 @@ where | |||
| B: Broadcast + 'static, | |||
| T: TxPool + 'static, | |||
| { | |||
| #[allow(clippy::arithmetic_side_effects)] | |||
There was a problem hiding this comment.
I guess clippy was ok when the future was boxed, but it started throwing this error when I removed it.
we still need the dependency because Runnable service uses it, I was thinking to remove in a follow up pr
There was a problem hiding this comment.
Maybe we can resolve it in this PR? Or is it too many changes?
There was a problem hiding this comment.
i wonder why it was not caught previously? wouldn't a boxed future also still have the same property that overflow is possible? weird
I think we still need it for implementing third-party traits in some places. But it would be great to get rid of it. |
still need for async_graphql, i tangled with it yesterday and did not have fun with it at all. |
Linked Issues/PRs
Description
should improve performance. breaking changes for anyone using fuel-core as a dependency, more specifically the
RunnableTasktrait. maybe cc: @FuelLabs/data-systems ?Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]