Refactor make create contract helper function available outside of fuel core #2656
+147
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acerone85
requested review from
xgreenx,
netrome,
rymnc,
Dentosal and
MitchTurner
as code owners
netrome
previously approved these changes
Jan 31, 2025
rymnc
previously approved these changes
Feb 3, 2025
Co-authored-by: Mårten Blankfors <[email protected]>
Co-authored-by: Mårten Blankfors <[email protected]>
acerone85
force-pushed
the
2587-fault_provingglobal_roots-populate-contractsrawcode-table
branch
from
ebe1f20 to
4177a75
Compare
acerone85
force-pushed
the
2654-refactor-make-create_contract-helper-function-available-outside-of-fuel-core
branch
from
c992c98 to
1ea8e97
Compare
acerone85
force-pushed
the
2587-fault_provingglobal_roots-populate-contractsrawcode-table
branch
3 times, most recently
from
e6aadd5 to
6bc31c6
Compare
Base automatically changed from
2587-fault_provingglobal_roots-populate-contractsrawcode-table
to
master
February 5, 2025 13:16
xgreenx
reviewed
Feb 10, 2025
| fn process_create_transaction(&mut self, tx: &Create) -> anyhow::Result<()> { | ||
| let bytecode_witness_index = tx.bytecode_witness_index(); | ||
| let witnesses = tx.witnesses(); | ||
| let bytecode = witnesses[usize::from(*bytecode_witness_index)].as_vec(); |
There was a problem hiding this comment.
It would be nice to use getter and process the case out of bounds
rafal-ch
reviewed
Feb 12, 2025
Comment on lines
+160
to
+166
| let Some(Output::ContractCreated { contract_id, .. }) = tx | ||
| .outputs() | ||
| .iter() | ||
| .filter(|output| matches!(output, Output::ContractCreated { .. })) | ||
| .take(1) | ||
| .collect::<Vec<&Output>>() | ||
| .first() |
There was a problem hiding this comment.
Will this work w/o the filter?
Suggested change
| let Some(Output::ContractCreated { contract_id, .. }) = tx | |
| .outputs() | |
| .iter() | |
| .filter(|output| matches!(output, Output::ContractCreated { .. })) | |
| .take(1) | |
| .collect::<Vec<&Output>>() | |
| .first() | |
| let Some(Output::ContractCreated { contract_id, .. }) = tx | |
| .outputs() | |
| .iter() | |
| .find(|output| matches!(output, Output::ContractCreated { .. })) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Closes #2654
Description
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]