Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wasm-executor): add nicer error if you missed a feature flag during compilation #2653

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rymnc
Copy link
Member

@rymnc rymnc commented Jan 31, 2025

Linked Issues/PRs

Description

found a lot of SerdeDeCustom errors while compiling #2648 without the fault-proving feature flag in the build script

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@rymnc rymnc force-pushed the wasm-executor/verbose-errors branch 2 times, most recently from 286639c to d55e3bf Compare January 31, 2025 09:54
@rymnc rymnc force-pushed the wasm-executor/verbose-errors branch from d55e3bf to 9f8f192 Compare January 31, 2025 18:10
@rymnc rymnc marked this pull request as ready for review February 3, 2025 05:32
AurelienFT
AurelienFT previously approved these changes Feb 3, 2025
CHANGELOG.md Outdated
Comment on lines 11 to 12
- [2553](https://github.com/FuelLabs/fuel-core/pull/2553): Scaffold global merkle root storage crate.
- [2598](https://github.com/FuelLabs/fuel-core/pull/2598): Add initial test suite for global merkle root storage updates.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice not to touch old changes in changelog=)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it got auto formatted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants