Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port(storage): use the cached block height from the database at the time of creation of the view #2646

Merged
merged 10 commits into from
Feb 11, 2025

Conversation

rymnc
Copy link
Member

@rymnc rymnc commented Jan 29, 2025

Linked Issues/PRs

Description

The most important changes include adding metadata support to the GenericDatabase, modifying type definitions to include height metadata, and updating various methods to use the new database structure.

Database Structure Improvements:

Code Refactoring:

Performance Improvements:

Test Updates:

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@rymnc rymnc force-pushed the port/cached-block-height branch from 9b36c1f to 9f9c35b Compare January 29, 2025 13:10
@rymnc rymnc marked this pull request as ready for review February 3, 2025 07:38
xgreenx
xgreenx previously approved these changes Feb 7, 2025
AurelienFT
AurelienFT previously approved these changes Feb 10, 2025
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already approved it for 0.40.3. Seems similar. Ty for porting

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Andrea Cerone <[email protected]>
@rymnc rymnc dismissed stale reviews from xgreenx and AurelienFT via eb5d006 February 10, 2025 17:40
@rymnc rymnc requested review from xgreenx and AurelienFT February 10, 2025 17:44
@rymnc rymnc enabled auto-merge (squash) February 11, 2025 08:45
@rymnc rymnc merged commit 8f0951e into master Feb 11, 2025
32 checks passed
@rymnc rymnc deleted the port/cached-block-height branch February 11, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants