-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port(storage): use the cached block height from the database at the time of creation of the view #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime of creation of the view
9b36c1f
to
9f9c35b
Compare
xgreenx
reviewed
Feb 7, 2025
xgreenx
previously approved these changes
Feb 7, 2025
9 tasks
AurelienFT
previously approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already approved it for 0.40.3. Seems similar. Ty for porting
acerone85
reviewed
Feb 10, 2025
Co-authored-by: Andrea Cerone <[email protected]>
AurelienFT
approved these changes
Feb 10, 2025
xgreenx
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Description
The most important changes include adding metadata support to the
GenericDatabase
, modifying type definitions to include height metadata, and updating various methods to use the new database structure.Database Structure Improvements:
crates/fuel-core/src/database.rs
: Added metadata support to theGenericDatabase
and updated type definitions to include height metadata. This includes changes to methods such asnew
,in_memory
, andlatest_view
. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]crates/fuel-core/src/state.rs
: Updated type definitions forIterableKeyValueView
andKeyValueView
to include height metadata. Modified theTransactableStorage
trait to use the new types. [1] [2] [3]Code Refactoring:
crates/fuel-core/src/state/generic_database.rs
: Refactored theGenericDatabase
struct to include metadata and updated various trait implementations to support the new structure. [1] [2] [3] [4] [5] [6] [7]Performance Improvements:
crates/fuel-core/src/database.rs
: Improved thelatest_height
method to use metadata for fetching the latest height, enhancing performance.Test Updates:
crates/fuel-core/src/service/genesis/importer/import_task.rs
: Updated tests to use the newKeyValueView
andIterableKeyValueView
types with height metadata.Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]