Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨(feat) Migrate to CKEditor 5 + allow back Php7.4 #260

Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,7 @@

# Documentation
/docs/_build/*

# IDE
.idea
src/Resources/public
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
}
],
"require": {
"php": "^8.0",
"php": "^7.4|^8.0",
"ext-zip": "*",
"ext-json": "*",
"symfony/asset": "^5.4 || ^6.0 || ^7.0",
Expand Down
10 changes: 5 additions & 5 deletions docs/usage/ckeditor.rst
Original file line number Diff line number Diff line change
Expand Up @@ -55,18 +55,18 @@ the bundle, you can use a custom path (absolute):
CKEditor Release
~~~~~~~~~~~~~~~~

You can choose which CKEditor release (full, standard or basic) to download:
You can choose which CKEditor release (classic, ballon, ballon-block, inline, document) to download:

.. code-block:: bash

$ php bin/console ckeditor:install --release=basic
$ php bin/console ckeditor:install --release=classic

CKEditor Custom Build
~~~~~~~~~~~~~~~~~~~~~

It's also possible to use custom build generated using CKEditor online builder:
https://ckeditor.com/cke4/builder. Download ZIP archive from CKEditor website
and use your custom build ID from `build-config.js` file:
https://ckeditor.com/ckeditor-5/online-builder/. Download ZIP archive from CKEditor website
and use your custom build ID from zip filename:

.. code-block:: bash

Expand All @@ -79,7 +79,7 @@ If your want a specific CKEditor version, you can use:

.. code-block:: bash

$ php bin/console ckeditor:install --tag=4.6.0
$ php bin/console ckeditor:install --tag=41.0.0

Silence Progress bars
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Expand Down
2 changes: 1 addition & 1 deletion src/Builder/JsonBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public function setValues(array $values, string $pathPrefix = null): self
return $this;
}

public function setValue(string $path, mixed $value, bool $escapeValue = true): self
public function setValue(string $path, $value, bool $escapeValue = true): self
{
if (!$escapeValue) {
$placeholder = uniqid('friendsofsymfony', true);
Expand Down
10 changes: 5 additions & 5 deletions src/Command/CKEditorInstallerCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,15 @@ protected function configure(): void
The <info>%command.name%</info> command install CKEditor in your application:

<info>php %command.full_name%</info>

You can install it at a specific path (absolute):

<info>php %command.full_name% path</info>

You can install a specific release (basic, standard or full):

<info>php %command.full_name% --release=full</info>

You can install a specific version:

<info>php %command.full_name% --tag=4.7.0</info>
Expand All @@ -99,13 +99,13 @@ protected function configure(): void

<info>php %command.full_name% --release=custom --custom-build-id=574a82a0d3e9226d94b0e91d10eaa372</info>

If there is a previous CKEditor installation detected,
If there is a previous CKEditor installation detected,
you can control how it should be handled in non-interactive mode:

<info>php %command.full_name% --clear=drop</info>
<info>php %command.full_name% --clear=keep</info>
<info>php %command.full_name% --clear=skip</info>

You can exclude path(s) when extracting CKEditor:

<info>php %command.full_name% --exclude=samples --exclude=adapters</info>
Expand Down
Loading
Loading