Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly show what options user voted for & make text more readable #79

Merged
merged 5 commits into from
Jul 25, 2023

Conversation

dsevillamartin
Copy link
Member

Refs #15

Changes proposed in this pull request:

  • If voting checkbox input is not shown, show checkmark next to percent
  • Reorganize DOM and use grid layout for general poll option
  • Remove PollOption as an absolute bar, use PollBar::after pseudoelement
  • Use mix-blend-mode for attempting to get readable text color
  • Fix selector highlighting voted options

Reviewers should focus on:
It's hard to find settings that work well for all scenarios - probably impossible. I believe this is an improvement over the current state, though. Some scenarios have worse legibility, but this allows those that barely had any to have some.

Maybe a setting can be introduced to let forums decide whether they want to use mix-blend-mode? Since the effects mostly depend on the selected primary & secondary colors, it might be a good idea to let them turn it off if it works better without.

Screenshot
image
image
image
image
image

Confirmed

  • Frontend changes: tested on a local Flarum installation.

@dsevillamartin dsevillamartin merged commit 59be77c into master Jul 25, 2023
@dsevillamartin dsevillamartin deleted the ds/poll-readability-improvements branch January 15, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants