Fix missing / non-array user.ranks() issue on v17development/flarum-support #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to v17development/flarum-support-feedback#14 which causes support page to break.
Changes proposed in this pull request:
This change adds a conditional check to make sure the
user.ranks()
is actually loaded. If the rank is falsey, it does not try to add user rank to the PostUser view.Reviewers should focus on:
Screenshot
This is how the support tickets page was breaking:
And here's the console log showing the
ranks()
trying toreverse()
which is not available since it's not an array:Confirmed
composer test
).Required changes:
N/A