Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PostUser name to to rankings-info #104

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

rob006
Copy link
Contributor

@rob006 rob006 commented Mar 12, 2023

Adjustments for flarum/framework#3732

  1. It uses class name instead of targeting h3 tag in find() call, so code should work after planned changes in Flarum 2.0.
  2. I switched used tag from h3 to div - this was originally planed in core, but was postponed to 2.0 because of BC break. In case of this extension BC break should have much less impact than in core, so it may be OK to switch early to markup planned for Flarum 2.0.

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Copy link
Member

@DavideIadeluca DavideIadeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @rob006 it's been a while..

I had some thoughts about this and generally I agree with what you've outlined here and in flarum/framework#3732.

Even though the impact of this change would me much smaller than in core, I'm still not comfortable with making that change right now, as it will inevitably break existing UI styling.

Therefore I would aim that we change this to a <div> only when we refactor the Extension for Flarum 2.x and keep it a h3 until then (with the newly added class).

@rob006
Copy link
Contributor Author

rob006 commented Oct 6, 2024

I reverted tag change.

@DavideIadeluca DavideIadeluca changed the title Do not use h3 tag for PostUser name Add PostUser name to to rankings-info Oct 7, 2024
@DavideIadeluca DavideIadeluca merged commit 5815635 into FriendsOfFlarum:master Oct 7, 2024
28 checks passed
@DavideIadeluca
Copy link
Member

Follow up issue to use

is created: #125

@rob006 rob006 deleted the post-user-name-tag branch October 7, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants