Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+Payment, PaymentTerm, PaymentService #41

Merged
merged 26 commits into from
Feb 4, 2025
Merged

+Payment, PaymentTerm, PaymentService #41

merged 26 commits into from
Feb 4, 2025

Conversation

mathielen
Copy link
Collaborator

+Custom DTD

@mathielen mathielen force-pushed the feature-payment branch 2 times, most recently from 93e0f5f to b981ba1 Compare January 28, 2025 07:47
* DtdValidator can be instantiated for a directory with DTDs `::forDtdDirectory()`
@mathielen mathielen force-pushed the feature-payment branch 3 times, most recently from befb3f0 to ff5103a Compare January 28, 2025 09:24
@@ -6,7 +6,6 @@

use JMS\Serializer\Annotation as Serializer;

#[Serializer\AccessorOrder(order: 'custom', custom: ['value'])]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you deleted this serializer property?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the need?

@ynnoig ynnoig added the enhancement New feature or request label Jan 28, 2025
@mathielen mathielen marked this pull request as draft January 30, 2025 13:15
@mathielen mathielen marked this pull request as ready for review February 4, 2025 14:26
@mathielen mathielen merged commit e39471a into main Feb 4, 2025
3 checks passed
@mathielen mathielen deleted the feature-payment branch February 4, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants