Fix reference data import with translations #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rybus
reviewed
Mar 16, 2018
| use Pim\Component\Connector\ArrayConverter\ArrayConverterInterface; | ||
| use Pim\Component\Connector\ArrayConverter\FieldsRequirementChecker; | ||
|
|
||
| class ReferenceData implements ArrayConverterInterface |
rybus
approved these changes
Mar 16, 2018
mmetayer
requested changes
Mar 19, 2018
There was a problem hiding this comment.
@MarieMinasyan : this issue was already fixed by #167, though only for PIM >= v2.1, plus your ArrayConverter seems nicer. Before we can merge, could you please add some specs and integration tests (you can take example on master branch)
| @@ -0,0 +1,79 @@ | |||
| <?php | |||
|
|
|||
| namespace Pim\Bundle\CustomEntityBundle\ArrayConverter\FlatToStandard; | |||
There was a problem hiding this comment.
Please move to Pim\Bundle\CustomEntityBundle\Connector\ArrayConverter\FlatToStandard, that'll make merges easier (this has already been fixed in the master branch)
…nnector\ArrayConverter\FlatToStandard
mmetayer
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
There is a problem in the ref data with translations import. They are ignored because the array converter didn't transform the flat array into a standard one, and in the updater no property "label-fr_FR" is found.
This PR fixes the issue.