Skip to content

Commit

Permalink
A few more html nits.
Browse files Browse the repository at this point in the history
Mostly, less <dl></dl>
  • Loading branch information
dlangille committed Jan 29, 2023
1 parent 5effffd commit 7579171
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions classes/port-display.php
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,7 @@ function Display() {
#####################################################

# start the description list for this port
$HTML .= "<dl>\n";
$HTML .= "<dl class=\"port-description\">\n";

if ($this->ShowEverything || $this->ShowShortDescription || $this->ShowCategory) {
# first term/name, is the port itself
Expand Down Expand Up @@ -1273,7 +1273,7 @@ function Display() {

# only show if we're meant to show, and if the port has not been deleted.
if ($this->ShowPackageLink || $this->ShowEverything) {
$HTML .= "\n</dl><dl>\n";
# $HTML .= "\n</dl><dl>\n";
if ($port->IsDeleted()) {
$HTML .= '<dt>No installation instructions:</dt><dd>This port has been deleted.</dd>';
} else {
Expand Down Expand Up @@ -1422,7 +1422,7 @@ function Display() {
$NumRows = $MasterSlave->FetchByMaster($port->category . '/' . $port->port);

if ($port->IsSlavePort() || $NumRows > 0) {
$HTML .= "\n</dl><hr>\n<dl>";
# $HTML .= "\n</dl><hr>\n<dl>";
}

if ($port->IsSlavePort()) {
Expand All @@ -1447,7 +1447,7 @@ function Display() {
}

if ($this->ShowDepends || $this->ShowEverything) {
$HTML .= "</dl>\n<hr><dl>\n";
# $HTML .= "</dl>\n<hr><dl>\n";
if ($port->depends_build || $port->depends_run || $port->depends_lib || $port->fetch_depends || $port->patch_depends || $port->extract_depends || $port->test_depends) {
$HTML .= '<dt class="h2" id="dependencies">Dependencies</dt>';
$HTML .= '<dt class="notice">NOTE: FreshPorts displays only information on required and default dependencies. Optional dependencies are not covered.</dt>';
Expand Down Expand Up @@ -1506,8 +1506,8 @@ function Display() {


if ($this->ShowEverything || $this->ShowConfig) {
$HTML .= "</dl>\n<hr>\n<dl>";
$HTML .= '<dt id="config"><b>Configuration Options</b>:</dt>' . "\n" . '<dd class="like-pre">';
# $HTML .= "\n<dl>";
$HTML .= '<dt id="config"><hr>' . "\n" . '<b>Configuration Options</b>:</dt>' . "\n" . '<dd class="like-pre">';
if ($port->showconfig) {
$HTML .= $port->showconfig;
} else {
Expand All @@ -1525,9 +1525,11 @@ function Display() {
}

if (($this->ShowEverything || $this->ShowUses) && $port->uses) {
$HTML .= '</dl><hr><dl><dt id="uses"><b>USES:</b></dt>' . "\n" . '<dd class="like-pre">';
# $HTML .= '</dl><hr><dl>';
$HTML .= '<dt id="uses"><b>USES:</b></dt>' . "\n" . '<dd class="like-pre">';
$HTML .= $port->uses;
$HTML .= "</dd>\n</dl>\n<hr>\n<dl>";
$HTML .= "</dd>\n";
# $HTML .= "</dl>\n<hr>\n<dl>";
}

if (($this->ShowEverything || $this->ShowPKGMessage)) {
Expand Down

0 comments on commit 7579171

Please sign in to comment.