Fix an SQL injection situation.

Reported by: Christian Inci - https://github.com/chris-pcguy
FreshPorts · Mar 18, 2023 · 08fbb1d · 08fbb1d
1 parent 9a9753b
commit 08fbb1d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/www/graphs/graph.php b/www/graphs/graph.php
@@ -38,7 +38,7 @@ function FreshPortsChart($title, $axislabel, $values, $labels, $urls, $file = "-
 // parameters:
 // id=number of graph
 
-$id = pg_escape_string($db, $_REQUEST["id"]);
+$id = intval(pg_escape_string($db, $_REQUEST["id"]));
 
 // assume that we always have graph of id=0
 if (!isset($id)) $id=0;
@@ -55,7 +55,7 @@ function FreshPortsChart($title, $axislabel, $values, $labels, $urls, $file = "-
 
 	// XXX CHANGE THE QUERY XXX
 	$data = @pg_exec($db, "select query, title, label, is_clickable from graphs where id = $id")
-		or die("PGERR 1: " . pg_ErrorMessage());
+		or die("PGERR 1: " . pg_ErrorMessage($db));
 
 	if (pg_num_rows($data) == 0)
 		die("GRAPH: invalid id");