Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add (optional) timeout config to prevent checkout crashes (error 504) #24

Open
wants to merge 1 commit into
base: 2.2-develop
Choose a base branch
from

Conversation

ivanaugustobds
Copy link

@ivanaugustobds ivanaugustobds commented Aug 1, 2022

Adds a new config to allow a timeout to be set (this prevents error 504 in checkout in case of api instabilities):
image

Some notes:

  • this feature is disabled by default, so unless the storekeeper explicitly enables this it will not affect the current behavior at all;
  • it relies on this enhancement on the php lib, and after the lib version update there this MUST BE reflected in the composer.json of this module (preview: https://github.com/FrenetGatewaydeFretes/frenet-magento2/pull/24/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34L12);
  • also, Déjà vu!

@ivanaugustobds ivanaugustobds changed the title feat: add support to timeout to prevent checkout crashes feat: add (optional) timeout config to prevent checkout crashes (error 504) Aug 1, 2022
@alexandercamps
Copy link
Contributor

Bom dia @ivanaugustobd !
Uma ideia muito boa mesmo, garantir que o módulo se proteja de algum momento de timeout da API de cotação.

Vou realizar testes da sua melhoria na versão de produção do plugin.

Abs,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants