Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] [translation] Fix translation build error. #685

Merged
merged 7 commits into from
Mar 31, 2024

Conversation

swashata
Copy link
Contributor

@swashata swashata commented Jan 30, 2024

  1. Update all gulp dependencies.
  2. Use the new transifex API to push and pull files.

TODOS

  • Add SaaS and JS build.
  • Add extra files to export-ignore
    • All CSS .map files.
    • Source JS files (assets/scripts)
    • patches directory
    • gulptasks directory
    • .example.env file
    • CONTRIBUTING.md file
    • package-lock.json
  • Compile all languages from the production source

NOTE FOR REVIEWER

  • For now the transifex upload is protected against production. So if we try to upload to the production project, it will bail as a failsafe. I will remove this once @fajardoleo has confirmed that the translations (languages/freemius.pot) produced by the new system is good.
  • I have removed the assets/js/nojquery.ba-postmessage.min.js file as now
    • The assets/scripts act as the source JS (uncompressed)
    • The assets/js acts as the build/compiled JS (compressed)
    • The PHP files enqueuing that script are also updated.
  • While updating the SASS compiler, I fixed some SASS and autoprefixer warnings.

@swashata swashata force-pushed the feature/fix-trasifex-automation branch 7 times, most recently from f0c5272 to 4336d48 Compare January 31, 2024 07:34
@swashata swashata requested a review from fajardoleo January 31, 2024 07:36
@swashata swashata marked this pull request as ready for review January 31, 2024 07:39
@swashata swashata requested a review from bahiirwa January 31, 2024 07:40
@swashata swashata force-pushed the feature/fix-trasifex-automation branch from a32d26c to 0f6b0f1 Compare March 31, 2024 09:38
@swashata swashata merged commit 0f6b0f1 into develop Mar 31, 2024
5 checks passed
@swashata swashata deleted the feature/fix-trasifex-automation branch March 31, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants