-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressed accessibility issues identified by Alison #2560
Open
AnneV-Learn
wants to merge
24
commits into
master
Choose a base branch
from
fc_1380_av
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressed accessibility issues identified by Alison - see ZenHub comment for Round 1 corrections
…03/22 Updates to RECORDS accessibility in response to Alison's comments 05/03/22
Updates for RECORDS Accessibility - tidy helper code
Implemented html changes recommended by Alison after further review. Includes changes up to and including 13/04
Corrections as previous modifications had problems
Main H1 heading extracted to partial and modified so that the date is not split over a line. Changed spacing for the input fields.
H1 Header and Nav mods
Updates for second set of comments on County page from Alison. Includes similar modifications to Place and Recent Additions pages.
Merge in latest Master (except County_index erb)
Resolve remaining Master conflicts in County Index erb
Names page updated to navigate within page and use lists for the actual names
remove blank lines in code
Show -NONE- when there are no names in a category
Remove lone <b> in h4 for starting with letter switch id for Additional names to h4 (was div)
Correct navigation links when coming from recent additions
Incorporate updates suggested by A O'Neill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed accessibility issues identified by Alison - see ZenHub comment for Round 1 corrections