Migrate ft-slider to the composition api #6677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
MarmadileManteater
requested review from
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
kommunarr
| @change="change" | ||
| > | ||
| <span> | ||
| {{ t('Display Label', {label: label, value: displayLabel}) }} |
There was a problem hiding this comment.
I may be wrong but I think we still use $t in the vue templates for the components we migrated to composition api (unless we're doing something wrong in the other components and need to update them)
Suggested change
| {{ t('Display Label', {label: label, value: displayLabel}) }} | |
| {{ $t('Display Label', {label: label, value: displayLabel}) }} |
|
|
||
| <script setup> | ||
| import { computed, ref } from 'vue' | ||
| import { randomUUID } from 'crypto' |
There was a problem hiding this comment.
I think useId should be used instead
https://github.com/FreeTubeApp/FreeTube/blob/development/src/renderer/composables/use-id-polyfill.js
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Feb 2, 2025
absidue
approved these changes
Feb 2, 2025
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate
ft-sliderto compisition apiPull Request Type
Description
This PR migrates the
FtSlidercomponent to the composition API.Testing
Desktop